Re: [PATCH 2/2] net: mdio: aspeed: Add AST2700 support

From: Krzysztof Kozlowski
Date: Thu Sep 05 2024 - 07:50:56 EST


On 05/09/2024 13:47, Jacky Chou wrote:
> Add AST2700 compatible for Aspeed MDIO driver.
>
> Signed-off-by: Jacky Chou <jacky_chou@xxxxxxxxxxxxxx>
> ---
> drivers/net/mdio/mdio-aspeed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
> index c2170650415c..607e5c56434f 100644
> --- a/drivers/net/mdio/mdio-aspeed.c
> +++ b/drivers/net/mdio/mdio-aspeed.c
> @@ -188,6 +188,7 @@ static void aspeed_mdio_remove(struct platform_device *pdev)
>
> static const struct of_device_id aspeed_mdio_of_match[] = {
> { .compatible = "aspeed,ast2600-mdio", },
> + { .compatible = "aspeed,ast2700-mdio", },

Why? They are compatible, aren't they? Write useful commit msgs so you
won't get simple questions on each review.

Best regards,
Krzysztof