Re: [PATCH 07/13] dt-bindings: media: camss: Add qcom,sm8550-camss binding

[Depeng Shao]

Hi Vladimir,

On 9/5/2024 11:20 PM, Vladimir Zapolskiy wrote:
> Hello Depeng.
>
> On 8/12/24 17:41, Depeng Shao wrote:
> > Add bindings for qcom,sm8550-camss in order to support the camera
> > subsystem for sm8550.
> >
> > Co-developed-by: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> > Signed-off-by: Yongsheng Li <quic_yon@xxxxxxxxxxx>
> > Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
>
> <snip>
>
> > +
> > +            interrupts = <GIC_SPI 601 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 603 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 431 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 605 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 376 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 477 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 478 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 479 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 448 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 277 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 604 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 688 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 606 IRQ_TYPE_LEVEL_HIGH>,
> > +                         <GIC_SPI 377 IRQ_TYPE_LEVEL_HIGH>;
>
> Please change all interrupt types to IRQ_TYPE_EDGE_RISING, this
> will match the type set by the camss driver itself, and I believe
> a rising edge interrupt here is correct.
>
> A similar change would be needed in the dts file change.

Sure, I will try this change. Thanks for the comments.

> > +
> > +            interrupt-names = "csid0",
> > +                              "csid1",
> > +                              "csid2",
> > +                              "csid_lite0",
> > +                              "csid_lite1",
> > +                              "csiphy0",
> > +                              "csiphy1",
> > +                              "csiphy2",
> > +                              "csiphy3",
> > +                              "csiphy4",
> > +                              "csiphy5",
> > +                              "csiphy6",
> > +                              "csiphy7",
> > +                              "vfe0",
> > +                              "vfe1",
> > +                              "vfe2",
> > +                              "vfe_lite0",
> > +                              "vfe_lite1";
>
> --
> Best wishes,
> Vladimir

Thanks,
Depeng