Re: [PATCH v1 1/1] x86/cpu: Mark flag_is_changeable_p() with __maybe_unused
From: Andy Shevchenko
Date: Thu Sep 05 2024 - 13:02:10 EST
On Thu, Sep 05, 2024 at 07:58:58PM +0300, Andy Shevchenko wrote:
> When flag_is_changeable_p() is unused, it prevents kernel builds
> with clang, `make W=1` and CONFIG_WERROR=y:
>
> arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> 351 | static inline int flag_is_changeable_p(u32 flag)
> | ^~~~~~~~~~~~~~~~~~~~
>
> Fix this by marking it with __maybe_unused.
>
> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> inline functions for W=1 build").
...and it should be done for 64-bit case.
--
With Best Regards,
Andy Shevchenko