Re: [PATCH v1 1/1] regulator: of: Refactor of_get_*regulator() to decrease indentation

[Andy Shevchenko]

On Thu, Sep 5, 2024 at 11:49 AM Chen-Yu Tsai <wenst@xxxxxxxxxxxx> wrote:
> On Thu, Sep 5, 2024 at 3:09 AM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> >
> > Refactor of_get_*regulator() to decrease indentation and increase readability.
> > No functional changes intended.
> >
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>

Thank you!

...

> > -                               goto err_node_put;
>
> Nit: I would probably rename this to out_node_put. But if we're going to
> move to the scoped helper, we might as well just skip it.

It's a bit out of the scope of this patch. And yes, if we go in that
direction it doesn't really matter. It will be replaced by direct
return calls anyway.

-- 
With Best Regards,
Andy Shevchenko