Re: [PATCHv3 net-next 2/9] net: ibm: emac: manage emac_irq with devm

From: Andrew Lunn
Date: Thu Sep 05 2024 - 17:17:57 EST


On Thu, Sep 05, 2024 at 01:14:59PM -0700, Rosen Penev wrote:
> It's the last to go in remove. Safe to let devm handle it.
>
> Also move request_irq to probe for clarity. It's removed in _remove not
> close.
>
> Use dev_err_probe instead of printk. Handles EPROBE_DEFER automatically.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew