Re: [PATCH v5] binder: modify the comment for binder_proc_unlock

From: Carlos Llamas
Date: Thu Sep 05 2024 - 18:44:57 EST


On Mon, Sep 02, 2024 at 01:23:30PM +0800, Ba Jing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which
> spinlock it releases and to better match the acquire comment block
> in binder_proc_lock().
>
> Signed-off-by: Ba Jing <bajing@xxxxxxxxxxxxxxxxxxxx>
> ---
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@xxxxxxxxxxxxxxxxxxxx/
>
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@xxxxxxxxxxxxxxxxxxxx/
>
> v3: Wrap commit message. Add version history.
> https://lore.kernel.org/all/20240902025720.2334-1-bajing@xxxxxxxxxxxxxxxxxxxx/
>
> v4: Modify the commit information.
> https://lore.kernel.org/all/20240902033754.2708-1-bajing@xxxxxxxxxxxxxxxxxxxx/
>
> v5: Change the format and wrap the changelog text at 72 columns.
>
> drivers/android/binder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index fc55b5d0e4f3..578861d57045 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
> }
>
> /**
> - * binder_proc_unlock() - Release spinlock for given binder_proc
> + * binder_proc_unlock() - Release outer lock for given binder_proc
> * @proc: struct binder_proc to acquire
> *
> * Release lock acquired via binder_proc_lock()
> --
> 2.33.0

Thanks,

Acked-by: Carlos Llamas <cmllamas@xxxxxxxxxx>