RE: [PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

From: Mohan.Prasad
Date: Fri Sep 06 2024 - 02:47:21 EST


Hello Andrew,

Thank you for your review comments.

> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
>
> On Wed, Sep 04, 2024 at 03:45:46AM +0530, Mohan Prasad J wrote:
> > This series of patches are for testing the lan743x network driver.
> > Testing comprises autonegotiation, speed, duplex and throughput checks.
> > Tools such as ethtool, iperf3 are used in the testing process.
> > Performance test is done for TCP streams at different speeds.
>
> What is specific to lan743x? Why won't the autoneg test work for any
> interface which says it supports autoneg? Is duplex somehow special on the
> lan743x?
>
> Where possible, please try to make these tests generic, usable on any NIC. Or
> clearly document why they cannot be generic.
>

As suggested, I will change the testcases to generic form and document them accordingly in the next version.

> Andrew