Re: [PATCH] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled

From: Mika Westerberg
Date: Fri Sep 06 2024 - 03:06:25 EST


On Fri, Sep 06, 2024 at 02:54:49PM +0800, Kimriver Liu wrote:
> It was observed issuing ABORT bit(IC_ENABLE[1]) will not work when
> IC_ENABLE is already disabled.
>
> Check if ENABLE bit(IC_ENABLE[0]) is disabled when the master is
> holding SCL low. If ENABLE bit is disabled, the software need
> enable it before trying to issue ABORT bit. otherwise,
> the controller ignores any write to ABORT bit.
>
> Signed-off-by: Kimriver Liu <kimriver.liu@xxxxxxxxxxxx>
>
> ---
> V4->V5: delete master idling checking

Hm, why did you do that? I suggested to consolidate the two into one
function (if possible) not drop it.