Re: [PATCH 00/13] ALSA: update sample rate definitions

From: Takashi Iwai
Date: Fri Sep 06 2024 - 03:27:22 EST


On Thu, 05 Sep 2024 16:12:51 +0200,
Jerome Brunet wrote:
>
> This patchset adds rate definitions for 12kHz, 24kHz and 128kHz.
>
> It is follow-up on the series/discussion [0] about adding 128kHz for
> spdif/eARC support. The outcome was to add 12kHz and 24kHz as well and
> clean up the drivers that no longer require custom rules to allow these
> rates.
>
> Identifying these drivers is not straight forward, I tried my best but I
> may have missed some. Those will continue to work anyway so it is not
> critical. Some drivers using these rates have not been changed on
> purpose. The reason for this may be:
> * The driver used other uncommon rates that still don't have a definition
> so a custom rule is still required.
> * The constraint structure is used in some other way by the driver and
> removing it would not help the readability or maintainability. This is
> the case the freescale asrc drivers for example.
>
> There is one change per driver so, if there is a problem later on, it will
> easier to properly add Fixes tag.
>
> The series has been tested with
> * ARM64 defconfig - spdif 128kHz at runtime.
> * x86_64 allmodconfig - compile test only
>
> Last, the change adding IEC958 definitions has been dropped for this
> patchset and will be resent separately
>
> [0]: https://lore.kernel.org/all/20240628122429.2018059-1-jbrunet@xxxxxxxxxxxx/
>
> ---
> Jerome Brunet (13):
> ALSA: pcm: add more sample rate definitions
> ALSA: cmipci: drop SNDRV_PCM_RATE_KNOT
> ALSA: emu10k1: drop SNDRV_PCM_RATE_KNOT
> ALSA: hdsp: drop SNDRV_PCM_RATE_KNOT
> ALSA: hdspm: drop SNDRV_PCM_RATE_KNOT
> ASoC: cs35l36: drop SNDRV_PCM_RATE_KNOT
> ASoC: cs35l41: drop SNDRV_PCM_RATE_KNOT
> ASoC: cs53l30: drop SNDRV_PCM_RATE_KNOT
> ASoC: Intel: avs: drop SNDRV_PCM_RATE_KNOT
> ASoC: qcom: q6asm-dai: drop SNDRV_PCM_RATE_KNOT
> ASoC: sunxi: sun4i-codec: drop SNDRV_PCM_RATE_KNOT
> ASoC: cs35l34: drop useless rate contraint
> ASoC: spdif: extend supported rates to 768kHz

A nice cleanup series.
Applied all now to for-next branch.


Thanks!

Takashi