[PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources_init()
From: Riyan Dhiman
Date: Fri Sep 06 2024 - 04:41:41 EST
Memory region and IO memory were not released if mtk_cpu_create_freq_table() failed.
Added error handling to ensure that IO memory is unmapped and the memory region is
released properly to prevent resource leaks and ensure all resources are cleaned up on error.
Signed-off-by: Riyan Dhiman <riyandhiman14@xxxxxxxxx>
---
drivers/cpufreq/mediatek-cpufreq-hw.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/mediatek-cpufreq-hw.c b/drivers/cpufreq/mediatek-cpufreq-hw.c
index 8925e096d5b9..3b1303f350ec 100644
--- a/drivers/cpufreq/mediatek-cpufreq-hw.c
+++ b/drivers/cpufreq/mediatek-cpufreq-hw.c
@@ -207,13 +207,15 @@ static int mtk_cpu_resources_init(struct platform_device *pdev,
ret = mtk_cpu_create_freq_table(pdev, data);
if (ret) {
dev_info(dev, "Domain-%d failed to create freq table\n", index);
- return ret;
+ goto unmap_region;
}
policy->freq_table = data->table;
policy->driver_data = data;
return 0;
+unmap_region:
+ iounmap(base);
release_region:
release_mem_region(res->start, resource_size(res));
return ret;
--
2.46.0