RE: [PATCH net] net: dsa: felix: ignore pending status of TAS module when it's disabled

[Xiaoliang Yang]

Hi Vladimir,

Yes, it's a user-visible problem. User can't reconfigured Qbv once the TAS is 
in pending status(configured the Qbv basetime as a future time). The driver 
always returns busy. Actually Qbv can be reconfigured after it's disabled. 
I update the commit to descript it and send in a new patch.

Thanks,
Xiaoliang

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@xxxxxxx>
> Sent: Wednesday, September 4, 2024 6:12 PM
> To: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Claudiu Manoil <claudiu.manoil@xxxxxxx>;
> alexandre.belloni@xxxxxxxxxxx; UNGLinuxDriver@xxxxxxxxxxxxx;
> andrew@xxxxxxx; f.fainelli@xxxxxxxxx; michael@xxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net] net: dsa: felix: ignore pending status of TAS module
> when it's disabled
> 
> Hi Xiaoliang,
> 
> On Wed, Sep 04, 2024 at 06:27:22PM +0800, Xiaoliang Yang wrote:
> > The TAS module could not be configured when it's running in pending
> > status. We need disable the module and configure it again. However,
> > the pending status is not cleared after the module disabled. So we
> > don't need to check the pending status if TAS module is disabled.
> >
> > Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@xxxxxxx>
> > ---
> 
> Does this fix a functional, user-visible problem? If so, which problem is that?
> Could you describe it in the commit message? And maybe add a Fixes: tag to
> the patch where the problem was first visible?