Re: [PATCH v2] arm64: dts: qcom: sa8775p-ride: add WiFi/BT nodes

From: Dmitry Baryshkov
Date: Fri Sep 06 2024 - 05:56:29 EST


On Fri, Sep 06, 2024 at 01:56:09PM GMT, Miaoqing Pan wrote:
> Add a node for the PMU module of the WCN6855 present on the sa8775p-ride
> board. Assign its LDO power outputs to the existing WiFi/Bluetooth module.
>
> Signed-off-by: Miaoqing Pan <quic_miaoqing@xxxxxxxxxxx>
> ---
> v2:
> - fix wcn6855-pmu compatible to "qcom,wcn6855-pmu".
> - relocate pcieport0 node in alphabetical order.
> ---
> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 119 +++++++++++++++++++++
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 2 +-
> 2 files changed, 120 insertions(+), 1 deletion(-)
>
> @@ -702,6 +793,23 @@ &pcie1_phy {
> status = "okay";
> };
>
> +&pcieport0 {
> + wifi@0 {
> + compatible = "pci17cb,1101";
> + reg = <0x10000 0x0 0x0 0x0 0x0>;
> +
> + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> + vddaon-supply = <&vreg_pmu_aon_0p59>;
> + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> + vddrfa1p7-supply = <&vreg_pmu_rfa_1p7>;
> + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
> + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;

Quoting review for v1:

Please add
qcom,ath11k-calibration-variant = "name"

No, "the WiFi node is for 'drivers/pci/pwrctl'" won't go.

> + };
> +};
> +
> &remoteproc_adsp {
> firmware-name = "qcom/sa8775p/adsp.mbn";
> status = "okay";

--
With best wishes
Dmitry