Re: [PATCH 08/15] mm/damon/core: Use generic upper bound recommondation for usleep_range()

[SeongJae Park]

On Wed, 04 Sep 2024 15:04:58 +0200 Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx> wrote:

> The upper bound for usleep_range_idle() was taken from the outdated
> documentation. As a recommondation for the upper bound of usleep_range()
> depends on HZ configuration it is not possible to hard code it.
> 
> Use the define "USLEEP_RANGE_UPPER_BOUND" instead.
> 
> Cc: SeongJae Park <sj@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: damon@xxxxxxxxxxxxxxx
> Cc: linux-mm@xxxxxxxxx
> Signed-off-by: Anna-Maria Behnsen <anna-maria@xxxxxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

> ---
>  mm/damon/core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 94fe2f1f9b0e..4b971871da75 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1883,8 +1883,7 @@ static unsigned long damos_wmark_wait_us(struct damos *scheme)
>  
>  static void kdamond_usleep(unsigned long usecs)
>  {
> -	/* See Documentation/timers/timers-howto.rst for the thresholds */
> -	if (usecs > 20 * USEC_PER_MSEC)
> +	if (usecs >= USLEEP_RANGE_UPPER_BOUND)
>  		schedule_timeout_idle(usecs_to_jiffies(usecs));
>  	else
>  		usleep_range_idle(usecs, usecs + 1);
> 
> -- 
> 2.39.2
> 
>