Re: [PATCH v2 2/2] selinux: move genheaders to security/selinux/

From: Paul Moore
Date: Fri Sep 06 2024 - 14:37:52 EST


On Fri, Sep 6, 2024 at 1:29 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>
> This tool is only used in security/selinux/Makefile.
>
> Move it to security/selinux/ so that 'make clean' can clean it up.
>
> Please note 'make clean' does not clean scripts/ because tools under
> scripts/ are often used for external module builds. Obviously, genheaders
> is not the case here.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> Changes in v2:
> - Add more reason to move genheaders to security/selinux/
>
> scripts/remove-stale-files | 3 +++
> scripts/selinux/Makefile | 2 +-
> scripts/selinux/genheaders/.gitignore | 2 --
> scripts/selinux/genheaders/Makefile | 3 ---
> security/selinux/.gitignore | 1 +
> security/selinux/Makefile | 7 +++++--
> .../selinux/genheaders => security/selinux}/genheaders.c | 0
> 7 files changed, 10 insertions(+), 8 deletions(-)
> delete mode 100644 scripts/selinux/genheaders/.gitignore
> delete mode 100644 scripts/selinux/genheaders/Makefile
> rename {scripts/selinux/genheaders => security/selinux}/genheaders.c (100%)

Better, thank you. See my comments on patch 1/2 for when you can
expect this to be merged into the SELinux tree.

--
paul-moore.com