Re: [PATCH v3 05/29] media: iris: implement iris v4l2 file ops
From: Markus Elfring
Date: Sat Sep 07 2024 - 04:52:32 EST
…
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h
> @@ -0,0 +1,13 @@
…
> +#ifndef _IRIS_HFI_GEN1_H_
> +#define _IRIS_HFI_GEN1_H_
…
I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier
Regards,
Markus