Re: [PATCH] cpufreq: mediatek-hw: Fix resource management and error handling in mtk_cpu_resources_init()

From: Markus Elfring
Date: Sat Sep 07 2024 - 12:10:46 EST


>>> Memory region and IO memory were not released if mtk_cpu_create_freq_table() failed.
>>> Added error handling to ensure that IO memory is unmapped and the memory region is
>>> released properly to prevent resource leaks and ensure all resources are cleaned up on error.
>>
>> * Would you like to improve such a change description another bit
>
> Should I elaborate a little more on the issue and explain the fix I have created?

Please take another look at guidance from linked information sources.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n94


>> also according to other line length preferences?
>
> Can you please help me a little bit about this?

Yes, of course.


> Is it the character lenght of subject?

Not directly.

The summary phrase can eventually become more succinct.


>> * How do you think about to add any tags (like "Fixes" and "Cc") accordingly?
>
> Should I change "patch" in subject to "Fixes" or …

Obviously not.

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc6#n145

Regards,
Markus