Re: [PATCH for-next] drm/ttm: make ttm_swap_ops static

[Matthew Brost]

On Sat, Sep 07, 2024 at 11:36:41AM +0800, Min-Hua Chen wrote:
> make ttm_swap_ops static to fix the following sparse warning:
> 
> drivers/gpu/drm/ttm/ttm_bo.c:1142:31: sparse: warning: symbol
> 'ttm_swap_ops' was not declared. Should it be static?
> 

This looks correct. I'd drop the 'Should it be static?' from commit
messge though. Assume a maintainer of TTM can drop at megre time.

With that:
Reviewed-by: Matthew Brost <matthew.brost@xxxxxxxxx>

> Fixes: 10efe34dae79 ("drm/ttm: Use the LRU walker helper for swapping")
> Signed-off-by: Min-Hua Chen <minhuadotchen@xxxxxxxxx>
> ---
>  drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 320592435252..1aab30767e41 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1139,7 +1139,7 @@ ttm_bo_swapout_cb(struct ttm_lru_walk *walk, struct ttm_buffer_object *bo)
>  	return ret;
>  }
>  
> -const struct ttm_lru_walk_ops ttm_swap_ops = {
> +static const struct ttm_lru_walk_ops ttm_swap_ops = {
>  	.process_bo = ttm_bo_swapout_cb,
>  };
>  
> -- 
> 2.43.0
>