Re: [PATCHv4 net-next 0/8] net: ibm: emac: modernize a bit

[Christophe JAILLET]

Le 07/09/2024 à 20:45, Rosen Penev a écrit :
> It's a very old driver with a lot of potential for cleaning up code to
> modern standards. This was a simple one dealing with mostly the probe
> function and adding some devm to it.
>
> v2: removed the waiting code in favor of EPROBE_DEFER.
> v3: reverse xmas order fix, unnecessary assignment fix, wrong usage of
> EPROBE_DEFER fix.
> v4: fixed line length warnings and unused goto.
>
> Rosen Penev (8):
>    net: ibm: emac: manage emac_irq with devm
>    net: ibm: emac: use devm for of_iomap
>    net: ibm: emac: remove mii_bus with devm
>    net: ibm: emac: use devm for register_netdev
>    net: ibm: emac: use netdev's phydev directly
>    net: ibm: emac: replace of_get_property
>    net: ibm: emac: remove all waiting code
>    net: ibm: emac: get rid of wol_irq
>
>   drivers/net/ethernet/ibm/emac/core.c | 210 +++++++++------------------
>   drivers/net/ethernet/ibm/emac/core.h |   4 -
>   2 files changed, 68 insertions(+), 146 deletions(-)
There was 9 patches in v3.

Patch 1/9: net: ibm: emac: use devm for alloc_etherdev is no more.
Is it removed intentionaly?

Also I made a comment on v3 6/9. It also apply to v4 5/9.

CJ