Re: [PATCH v2 2/2] of/irq: Use helper to define resources

From: Krzysztof Kozlowski
Date: Sun Sep 08 2024 - 04:44:30 EST


On Thu, Sep 05, 2024 at 11:34:54AM +0300, Andy Shevchenko wrote:
> On Wed, Sep 04, 2024 at 06:02:38PM +0200, Vasileios Amoiridis wrote:
> > Resources definition can become simpler and more organised by using the
> > dedicated helpers.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> ...
>
> > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev))
>
> Just use Elvis to make this shorten.
> Btw, have you ever compiled this?

It wasn't ever built... and if not built, probably not tested, either.

Best regards,
Krzysztof