Re: [PATCH 4/5] LoongArch: Extract IOCSR definitions to standalone header
From: kernel test robot
Date: Sun Sep 08 2024 - 12:57:46 EST
Hi Jiaxun,
kernel test robot noticed the following build errors:
[auto build test ERROR on 9aaeb87ce1e966169a57f53a02ba05b30880ffb8]
url: https://github.com/intel-lab-lkp/linux/commits/Jiaxun-Yang/LoongArch-Rename-cpu_has_csr-as-cpu_has_iocsr/20240907-181959
base: 9aaeb87ce1e966169a57f53a02ba05b30880ffb8
patch link: https://lore.kernel.org/r/20240907-iocsr-v1-4-0c99b3334444%40flygoat.com
patch subject: [PATCH 4/5] LoongArch: Extract IOCSR definitions to standalone header
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240909/202409090054.D3vEaTqr-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240909/202409090054.D3vEaTqr-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409090054.D3vEaTqr-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from arch/loongarch/include/asm/cpu-info.h:11,
from arch/loongarch/include/asm/processor.h:13,
from arch/loongarch/include/asm/thread_info.h:15,
from include/linux/thread_info.h:60,
from include/asm-generic/current.h:6,
from ./arch/loongarch/include/generated/asm/current.h:1,
from include/linux/mutex.h:14,
from include/linux/notifier.h:14,
from include/linux/clk.h:14,
from include/linux/cpufreq.h:11,
from drivers/cpufreq/loongson3_cpufreq.c:10:
drivers/cpufreq/loongson3_cpufreq.c: In function 'do_service_request':
>> drivers/cpufreq/loongson3_cpufreq.c:185:35: error: 'LOONGSON_IOCSR_SMCMBX' undeclared (first use in this function)
185 | last.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
| ^~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/loongson3_cpufreq.c:185:22: note: in expansion of macro 'iocsr_read32'
185 | last.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
| ^~~~~~~~~~~~
drivers/cpufreq/loongson3_cpufreq.c:185:35: note: each undeclared identifier is reported only once for each function it appears in
185 | last.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
| ^~~~~~~~~~~~~~~~~~~~~
drivers/cpufreq/loongson3_cpufreq.c:185:22: note: in expansion of macro 'iocsr_read32'
185 | last.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
| ^~~~~~~~~~~~
>> drivers/cpufreq/loongson3_cpufreq.c:199:36: error: 'LOONGSON_IOCSR_MISC_FUNC' undeclared (first use in this function)
199 | iocsr_write32(iocsr_read32(LOONGSON_IOCSR_MISC_FUNC) | IOCSR_MISC_FUNC_SOFT_INT,
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/loongarch/include/asm/loongarch.h:187:45: note: in definition of macro 'iocsr_write32'
187 | #define iocsr_write32(val, reg) __iocsrwr_w(val, reg)
| ^~~
drivers/cpufreq/loongson3_cpufreq.c:199:23: note: in expansion of macro 'iocsr_read32'
199 | iocsr_write32(iocsr_read32(LOONGSON_IOCSR_MISC_FUNC) | IOCSR_MISC_FUNC_SOFT_INT,
| ^~~~~~~~~~~~
>> drivers/cpufreq/loongson3_cpufreq.c:199:64: error: 'IOCSR_MISC_FUNC_SOFT_INT' undeclared (first use in this function)
199 | iocsr_write32(iocsr_read32(LOONGSON_IOCSR_MISC_FUNC) | IOCSR_MISC_FUNC_SOFT_INT,
| ^~~~~~~~~~~~~~~~~~~~~~~~
arch/loongarch/include/asm/loongarch.h:187:45: note: in definition of macro 'iocsr_write32'
187 | #define iocsr_write32(val, reg) __iocsrwr_w(val, reg)
| ^~~
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX
Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3)
Selected by [m]:
- TI_K3_M4_REMOTEPROC [=m] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y])
vim +/LOONGSON_IOCSR_SMCMBX +185 drivers/cpufreq/loongson3_cpufreq.c
175
176 static inline int do_service_request(u32 id, u32 info, u32 cmd, u32 val, u32 extra)
177 {
178 int retries;
179 unsigned int cpu = raw_smp_processor_id();
180 unsigned int package = cpu_data[cpu].package;
181 union smc_message msg, last;
182
183 mutex_lock(&cpufreq_mutex[package]);
184
> 185 last.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
186 if (!last.complete) {
187 mutex_unlock(&cpufreq_mutex[package]);
188 return -EPERM;
189 }
190
191 msg.id = id;
192 msg.info = info;
193 msg.cmd = cmd;
194 msg.val = val;
195 msg.extra = extra;
196 msg.complete = 0;
197
198 iocsr_write32(msg.value, LOONGSON_IOCSR_SMCMBX);
> 199 iocsr_write32(iocsr_read32(LOONGSON_IOCSR_MISC_FUNC) | IOCSR_MISC_FUNC_SOFT_INT,
200 LOONGSON_IOCSR_MISC_FUNC);
201
202 for (retries = 0; retries < 10000; retries++) {
203 msg.value = iocsr_read32(LOONGSON_IOCSR_SMCMBX);
204 if (msg.complete)
205 break;
206
207 usleep_range(8, 12);
208 }
209
210 if (!msg.complete || msg.cmd != CMD_OK) {
211 mutex_unlock(&cpufreq_mutex[package]);
212 return -EPERM;
213 }
214
215 mutex_unlock(&cpufreq_mutex[package]);
216
217 return msg.val;
218 }
219
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki