Re: [PATCH] hwmon: (pmbus/mpq7932) Constify struct regulator_desc

From: Guenter Roeck
Date: Sun Sep 08 2024 - 19:38:22 EST


On Sun, Sep 08, 2024 at 10:32:38AM +0200, Christophe JAILLET wrote:
> 'struct regulator_desc' is not modified in this driver.
>
> Constifying this structure moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
>
> This also makes mpq7932_regulators_desc consistent with
> mpq7932_regulators_desc_one which is already a "static const struct
> regulator_desc".
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 3516 2264 0 5780 1694 drivers/hwmon/pmbus/mpq7932.o
>
> After:
> =====
> text data bss dec hex filename
> 5396 384 0 5780 1694 drivers/hwmon/pmbus/mpq7932.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---

Applied.

Thanks,
Guenter