Re: [PATCH] erofs: fix incorrect symlink detection in fast symlink

From: Gao Xiang
Date: Sun Sep 08 2024 - 22:37:51 EST




On 2024/9/9 10:28, Gao Xiang wrote:
Fast symlink can be used if the on-disk symlink data is stored
in the same block as the on-disk inode, so we don’t need to trigger
another I/O for symlink data. However, correctly fs correction could be
reported _incorrectly_ if inode xattrs are too large.

In fact, these should be valid images although they cannot be handled as
fast symlinks.

Many thanks to Colin for reporting this!

Reported-by: Colin Walters <walters@xxxxxxxxxx>
Signed-off-by: Gao Xiang <hsiangkao@xxxxxxxxxxxxxxxxx>

Fixes: 431339ba9042 ("staging: erofs: add inode operations")

Thanks,
Gao Xiang