Re: [Patch v4 0/6] Bug fixes on topdown events reordering

[Mi, Dapeng]

On 8/17/2024 8:39 PM, Liang, Kan wrote:
>
> On 2024-08-16 8:29 a.m., Dapeng Mi wrote:
>> Changes:
>> v3 -> v4:
>>   * limit metrics event searching inside group for group leader
>>     sampling (Kan)
>>   * add comments to illustrate supported and unsupported topdown events
>>     regrouping formats (Kan)
>>   * add more test cases to verify supported topdown regrouping
>>     formats (Kan)
>>
>> History:
>>   v3: https://lore.kernel.org/all/20240712170339.185824-1-dapeng1.mi@xxxxxxxxxxxxxxx/
>>   v2: https://lore.kernel.org/all/20240708144204.839486-1-dapeng1.mi@xxxxxxxxxxxxxxx/
>>   v1: https://lore.kernel.org/all/20240702224037.343958-1-dapeng1.mi@xxxxxxxxxxxxxxx/
>>
>> Dapeng Mi (6):
>>   perf x86/topdown: Complete topdown slots/metrics events check
>>   perf x86/topdown: Correct leader selection with sample_read enabled
>>   perf x86/topdown: Don't move topdown metric events in group
>>   perf tests: Add leader sampling test in record tests
>>   perf tests: Add topdown events counting and sampling tests
>>   perf tests: Add more topdown events regroup tests
>
> Thanks Dapeng.
>
> The series look good to me.
>
> Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks Kan for reviewing. Any other comments?


>
> Thanks,
> Kan
>>  tools/perf/arch/x86/util/evlist.c  | 68 ++++++++++++++++++++++++++++--
>>  tools/perf/arch/x86/util/evsel.c   |  3 +-
>>  tools/perf/arch/x86/util/topdown.c | 64 +++++++++++++++++++++++++++-
>>  tools/perf/arch/x86/util/topdown.h |  2 +
>>  tools/perf/tests/shell/record.sh   | 45 ++++++++++++++++++++
>>  tools/perf/tests/shell/stat.sh     | 28 +++++++++++-
>>  6 files changed, 201 insertions(+), 9 deletions(-)
>>
>>
>> base-commit: 7c626ce4bae1ac14f60076d00eafe71af30450ba