Re: [PATCH RFC 0/3] amba: bus: Move reading periphid operation from amba_match() to amba_probe()

[Saravana Kannan]

On Sun, Sep 8, 2024 at 4:38 PM Zijun Hu <zijun_hu@xxxxxxxxxx> wrote:
>
> This patch series is to make amba_match(), as bus_type @amba_bustype's
> match(), also follow below ideal rule:
>
> bus_type's match() should only return bool type compatible integer 0 or
> 1 ideally since its main operations are lookup and comparison normally.
>
> Which has been followed by match() of all other bus_types in current
> kernel tree.

The intent or need for this patch series is completely unclear. The
code you are moving around was also pretty delicate and hard to get
right.

Without a much better description for why we need this, I'd like to
give this a NACK.

Also, patch 3/3 is not at all easy to understand and seems to be doing
way more than what the commit message is trying to do.

-Saravana

>
> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
> ---
> Zijun Hu (3):
>       amba: bus: Warn on adding an AMBA device without valid periphid
>       amba: bus: Move empty @amba_proxy_drv's definition to the front
>       amba: bus: Move reading periphid operation from amba_match() to amba_probe()
>
>  drivers/amba/bus.c       | 130 ++++++++++++++++++++++++++---------------------
>  include/linux/amba/bus.h |   1 -
>  2 files changed, 72 insertions(+), 59 deletions(-)
> ---
> base-commit: 888f67e621dda5c2804a696524e28d0ca4cf0a80
> change-id: 20240829-fix_amba-0f09aa1fc3b1
>
> Best regards,
> --
> Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>