Re: [PATCH 1/6] staging: rtl8723bs: fix use of tab wherever possible

[Sayyad Abid]

On Mon, Sep 9, 2024 at 1:53 AM Philipp Hortmann
<philipp.g.hortmann@xxxxxxxxx> wrote:
>
> On 9/8/24 12:11, Sayyad Abid wrote:
> > This patch fixes the coding style issue by fixing the use of space
> > instead of tabs on line.
> >
> > Signed-off-by: Sayyad Abid <sayyad.abid16@xxxxxxxxx>
>
> Hi Sayyad,
>
> please make your "Subject" line more unique. Consider that we may end up
> with having dozen of commits like yours, all of them referring to
> different removals and all without the necessary information to tell
> what they differ in (except the driver/subsystem). So it would help if
> you add the changed file or function to make it more unique.
>
Roger that, I'll keep that in mind while sending future patches.
> Please also improve the Subject Lines of the other patches.
>
sure, will do.
> If you send in a second version of this patch please use a change
> history. Description from Dan under:
> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
I think I am having some issues with the local repository,
I'll rebase and check again for the discrepancies. If the issue persists,
I will send a v2.
>
> Thanks for your support.
>
> Bye Philipp
>
> >
> > ---
> >   drivers/staging/rtl8723bs/include/rtw_security.h | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
> > index 98afbd3054a4..487d69460cec 100644
> > --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> > +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> > @@ -75,8 +75,8 @@ struct {
> >   };
> >
> >   union Keytype {
> > -        u8   skey[16];
> > -        u32    lkey[4];
> > +     u8   skey[16];
> > +     u32    lkey[4];
> >   };
> >
> >
>
Thanks for pointing out the issues.


-- 
Abid