Re: [PATCH 4/6] staging: rtl8723bs: fix comment with a trailing */ on a separate line

[Sayyad Abid]

On Mon, Sep 9, 2024 at 1:56 AM Philipp Hortmann
<philipp.g.hortmann@xxxxxxxxx> wrote:
>
> On 9/8/24 12:11, Sayyad Abid wrote:
> > This patch fixes the trailing "*/" on a comment block.
>
> Hi Sayyad,
>
> important is to describe why this patch makes the code better. You
> described in the description just what you did. But that can be seen in
> the changed lines blow.
>
Note, I'll add a descriptive summary of the "why" for the patches.
> Thanks
>
> Bye Philipp
>
> >
> > Signed-off-by: Sayyad Abid <sayyad.abid16@xxxxxxxxx>
> >
> > ---
> >   drivers/staging/rtl8723bs/include/rtw_security.h | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/include/rtw_security.h b/drivers/staging/rtl8723bs/include/rtw_security.h
> > index 4efa2d258ebf..1e5e7f52f8da 100644
> > --- a/drivers/staging/rtl8723bs/include/rtw_security.h
> > +++ b/drivers/staging/rtl8723bs/include/rtw_security.h
> > @@ -240,7 +240,8 @@ struct mic_data {
> >   /* ===== start - public domain SHA256 implementation ===== */
> >
> >   /* This is based on SHA256 implementation in LibTomCrypt that was released into
> > - * public domain by Tom St Denis. */
> > + * public domain by Tom St Denis.
> > + */
> >
> >   int omac1_aes_128(u8 *key, u8 *data, size_t data_len, u8 *mac);
> >   void rtw_secmicsetkey(struct mic_data *pmicdata, u8 *key);
>
Thank you!

-- 
Abid