Re: [PATCH] mtd: spi-nor: fix flash probing
From: Tudor Ambarus
Date: Mon Sep 09 2024 - 04:11:12 EST
On 9/9/24 8:52 AM, Miquel Raynal wrote:
> Hey,
>
Hiya
> tudor.ambarus@xxxxxxxxxx wrote on Mon, 9 Sep 2024 08:35:23 +0100:
>
>> On 9/9/24 8:28 AM, Michael Walle wrote:
>>> Fix flash probing by name. Flash entries without a name are allowed
>>> since commit 15eb8303bb42 ("mtd: spi-nor: mark the flash name as
>>> obsolete"). But it was just until recently that a flash entry without a
>>> name was actually introduced. This triggers a bug in the legacy probe by
>>> name path. Skip entries without a name to fix it.
>>>
>>> Fixes: 2095e7da8049 ("mtd: spi-nor: spansion: Add support for S28HS256T")
>>> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>>> Closes: https://lore.kernel.org/r/66c8ebb0-1324-4ad9-9926-8d4eb7e1e63a@xxxxxxxxxx/
>>> Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>>> Signed-off-by: Michael Walle <mwalle@xxxxxxxxxx>
>>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
>
> This patch will only apply on top of spi-nor/next. It would spend more
> time in -next if one of you applied it to this branch before sending
> the MR?
>
The patch is intended for spi-nor/next indeed, as the blamed commit was
just recently queued. No need to take it through mtd/fixes. Pratyush
will take it via spi-nor/next.
Cheers,
ta