Re: [PATCH v4 3/3] i2c: jz4780: Use dev_err_probe()

[Andy Shevchenko]

On Mon, Sep 09, 2024 at 10:23:30AM +0200, Andi Shyti wrote:
> On Tue, Aug 27, 2024 at 11:48:41AM GMT, Rong Qianfeng wrote:

...

> > +	struct device *dev = &pdev->dev;
> 
> I'm not a big fan of this change. There is not much gain in
> polluting git bisect in order to shorten pdev->dev to a single
> dev.
> 
> However, I like the /dev_err/dev_err_probe/.
> 
> I will take the first two patches from this series, but I will
> leave this if anyone else has a stronger opinion. If you want,
> you can send just this one patch with just the dev_err_probe()
> change.

Usually I combined this with conversion to dev_err_probe() et al.
so it makes new lines a bit shorter and hence readability a bit better.
On its own it's indeed questionable change.

-- 
With Best Regards,
Andy Shevchenko