Re: [PATCH] clk: ralink: mtmips: fix clock plan for Ralink SoC RT3883

[Shiji Yang]

On Tue,  6 Aug 2024 16:29:02 +0200, Sergio Paracuellos wrote:

>diff --git a/drivers/clk/ralink/clk-mtmips.c b/drivers/clk/ralink/clk-mtmips.c
>index 50a443bf79ec..787ff3e66b34 100644
>--- a/drivers/clk/ralink/clk-mtmips.c
>+++ b/drivers/clk/ralink/clk-mtmips.c
>@@ -267,6 +267,11 @@ static struct mtmips_clk_fixed rt305x_fixed_clocks[] = {
> 	CLK_FIXED("xtal", NULL, 40000000)
> };
> 
>+static struct mtmips_clk_fixed rt3383_fixed_clocks[] = {

Hi! I found a small issue. The SoC name is rt3883 instead of rt3383.

>+	CLK_FIXED("xtal", NULL, 40000000),
>+	CLK_FIXED("periph", "xtal", 40000000)
>+};
>+
> static struct mtmips_clk_fixed rt3352_fixed_clocks[] = {
> 	CLK_FIXED("periph", "xtal", 40000000)
> };
>@@ -779,8 +784,8 @@ static const struct mtmips_clk_data rt3352_clk_data = {
> static const struct mtmips_clk_data rt3883_clk_data = {
> 	.clk_base = rt3883_clks_base,
> 	.num_clk_base = ARRAY_SIZE(rt3883_clks_base),
>-	.clk_fixed = rt305x_fixed_clocks,
>-	.num_clk_fixed = ARRAY_SIZE(rt305x_fixed_clocks),
>+	.clk_fixed = rt3383_fixed_clocks,
>+	.num_clk_fixed = ARRAY_SIZE(rt3383_fixed_clocks),
> 	.clk_factor = NULL,
> 	.num_clk_factor = 0,
> 	.clk_periph = rt5350_pherip_clks,

Regards,
Shiji Yang