Re: [PATCHv6 2/4] x86/tdx: Rename tdx_parse_tdinfo() to tdx_setup()

[Kirill A. Shutemov]

On Wed, Aug 28, 2024 at 04:53:57PM +0300, Nikolay Borisov wrote:
> 
> 
> On 28.08.24 г. 12:35 ч., Kirill A. Shutemov wrote:
> > Rename tdx_parse_tdinfo() to tdx_setup() and move setting NOTIFY_ENABLES
> > there.
> > 
> > The function will be extended to adjust TD configuration.
> 
> <offtopic>
> Since this deals with renaming, I think it will make sense to rename
> tdx_early_init() to tdx_guest_init/tdx_guest_early_init as it becomes
> confusing as to which parts of the TDX pertain to the host and which to the
> guest. Right now we only have the guest portions under arch/x86/coco/tdx but
> when the kvm/vmx stuff land things will become somewhat messy..
> </offtopic>

I don't see a problem with the current state. KVM side will land under
arch/x86/virt/vmx/tdx, so the path will give it away.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov