Re: [PATCH v2 3/4] soc: qcom: geni-se: Export function geni_se_clks_off()

From: Konrad Dybcio
Date: Mon Sep 09 2024 - 07:35:29 EST


On 6.09.2024 9:14 PM, Mukesh Kumar Savaliya wrote:
> Currently the driver provides a function called geni_serial_resources_off()
> to turn off resources like clocks and pinctrl. We don't have a function to
> control clocks separately hence, export the function geni_se_clks_off() to
> turn off clocks separately without disturbing GPIO.
>
> Client drivers like I2C require this function for use-cases where the I2C
> SE is shared between two subsystems.
>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
> ---

Well, i2c is probably not the only type of client you'll want
to share and the current approach requires changes in all protocol
drivers.

How about adding a parameter like `bool shared_se` to
geni_se_resources_off() and changing the pinctrl state conditionally?

Konrad