Re: [PATCH v4 2/3] pmdomain: ti_sci: add wakeup constraint management

From: Markus Schneider-Pargmann
Date: Mon Sep 09 2024 - 09:47:05 EST


On Fri, Sep 06, 2024 at 09:14:50AM GMT, Kevin Hilman wrote:
> During system-wide suspend, check all devices connected to PM domain
> to see if they are wakeup-enabled. If so, set a TI SCI device
> constraint.
>
> Note: DM firmware clears all constraints on resume.
>
> Co-developed-by: Vibhore Vardhan <vibhore@xxxxxx>
> Signed-off-by: Vibhore Vardhan <vibhore@xxxxxx>
> Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> Tested-by: Dhruva Gole <d-gole@xxxxxx>
> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxx>

Reviewed-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx>

Best
Markus

> ---
> drivers/pmdomain/ti/ti_sci_pm_domains.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/pmdomain/ti/ti_sci_pm_domains.c b/drivers/pmdomain/ti/ti_sci_pm_domains.c
> index bb95c40ab3ea..1ab1e46924ab 100644
> --- a/drivers/pmdomain/ti/ti_sci_pm_domains.c
> +++ b/drivers/pmdomain/ti/ti_sci_pm_domains.c
> @@ -74,6 +74,21 @@ static void ti_sci_pd_set_lat_constraint(struct device *dev, s32 val)
> pd->idx, val);
> }
>
> +static inline void ti_sci_pd_set_wkup_constraint(struct device *dev)
> +{
> + struct generic_pm_domain *genpd = pd_to_genpd(dev->pm_domain);
> + struct ti_sci_pm_domain *pd = genpd_to_ti_sci_pd(genpd);
> + const struct ti_sci_handle *ti_sci = pd->parent->ti_sci;
> + int ret;
> +
> + if (device_may_wakeup(dev)) {
> + ret = ti_sci->ops.pm_ops.set_device_constraint(ti_sci, pd->idx,
> + TISCI_MSG_CONSTRAINT_SET);
> + if (!ret)
> + dev_dbg(dev, "ti_sci_pd: ID:%d set device constraint.\n", pd->idx);
> + }
> +}
> +
> /*
> * ti_sci_pd_power_off(): genpd power down hook
> * @domain: pointer to the powerdomain to power off
> @@ -115,6 +130,8 @@ static int ti_sci_pd_suspend(struct device *dev)
> if (ti_sci_pd_is_valid_constraint(val))
> ti_sci_pd_set_lat_constraint(dev, val);
>
> + ti_sci_pd_set_wkup_constraint(dev);
> +
> return 0;
> }
>
>
> --
> 2.46.0
>