Re: [PATCH v3 6/9] tmpfs: Add casefold lookup support

From: Gabriel Krisman Bertazi
Date: Mon Sep 09 2024 - 10:15:54 EST


André Almeida <andrealmeid@xxxxxxxxxx> writes:

>> The sole reason you are doing this custom function is to exclude negative
>> dentries from casefolded directories. I doubt we care about the extra
>> check being done. Can we just do it in simple_lookup?
>
> So, in summary:
>
> * set d_ops at mount time to generic_ci_always_del_dentry_ops
> * use simple_lookup(), get rid of shmem_lookup()
> * inside of simple_lookup(), add (IS_CASEFOLDED(dir)) return NULL
>
> Right?

Yep, that's my suggestion.

--
Gabriel Krisman Bertazi