Re: [PATCH v2 1/1] x86/cpu: Mark flag_is_changeable_p() with __maybe_unused

From: Andy Shevchenko
Date: Mon Sep 09 2024 - 11:43:24 EST


On Mon, Sep 09, 2024 at 08:35:43AM -0700, Dave Hansen wrote:
> On 9/5/24 10:02, Andy Shevchenko wrote:

...

> > arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> > 351 | static inline int flag_is_changeable_p(u32 flag)
> > | ^~~~~~~~~~~~~~~~~~~~
> >
> > Fix this by marking it with __maybe_unused (both cases for the sake of
> > symmetry).
> >
> > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> > inline functions for W=1 build").
>
> Maybe something like this:
>
> http://hansen.beer/~dave/intel/onelessifdef.patch

Fine to me as long as the issue is solved :-) Please, submit it formally I may
test it.

--
With Best Regards,
Andy Shevchenko