Re: [PATCH v2 net] dt-bindings: net: tja11xx: fix the broken binding
From: Rob Herring (Arm)
Date: Mon Sep 09 2024 - 12:04:20 EST
On Mon, 09 Sep 2024 09:21:52 +0800, Wei Fang wrote:
> As Rob pointed in another mail thread [1], the binding of tja11xx PHY
> is completely broken, the schema cannot catch the error in the DTS. A
> compatiable string must be needed if we want to add a custom propety.
> So extract known PHY IDs from the tja11xx PHY drivers and convert them
> into supported compatible string list to fix the broken binding issue.
>
> [1]: https://lore.kernel.org/netdev/31058f49-bac5-49a9-a422-c43b121bf049@xxxxxxxxxx/T/
>
> Fixes: 52b2fe4535ad ("dt-bindings: net: tja11xx: add nxp,refclk_in property")
> Signed-off-by: Wei Fang <wei.fang@xxxxxxx>
> ---
> V2 changes:
> 1. Add more compatible strings based on TJA11xx data sheets.
> V1 link: https://lore.kernel.org/imx/20240904145720.GA2552590-robh@xxxxxxxxxx/T/
> ---
> .../devicetree/bindings/net/nxp,tja11xx.yaml | 62 ++++++++++++++-----
> 1 file changed, 46 insertions(+), 16 deletions(-)
>
Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>