RE: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID

[Thangaraj, Senthil Nathan]

Hi Sai Krishna,

Please find my review below.

Thanks,
Senthil

> -----Original Message-----
> From: linux-arm-kernel <linux-arm-kernel-bounces@xxxxxxxxxxxxxxxxxxx> On
> Behalf Of Sai Krishna Potthuri
> Sent: Friday, September 6, 2024 4:01 AM
> To: Linus Walleij <linus.walleij@xxxxxxxxxx>; Simek, Michal
> <michal.simek@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>;
> Buddhabhatti, Jay <jay.buddhabhatti@xxxxxxx>; Kundanala, Praveen Teja
> <praveen.teja.kundanala@xxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> gpio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> saikrishna12468@xxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx>; Potthuri, Sai
> Krishna <sai.krishna.potthuri@xxxxxxx>
> Subject: [PATCH v5 2/3] firmware: xilinx: Add Pinctrl Get Attribute ID
> 
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
> 
> 
> Add Pinctrl Get Attribute ID to the query ids list.
> 
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@xxxxxxx>
> ---
>  include/linux/firmware/xlnx-zynqmp.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/firmware/xlnx-zynqmp.h
> b/include/linux/firmware/xlnx-zynqmp.h
> index d7d07afc0532..3b4ce4ec5d3f 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -238,6 +238,7 @@ enum pm_query_id {
>         PM_QID_PINCTRL_GET_PIN_GROUPS = 11,
>         PM_QID_CLOCK_GET_NUM_CLOCKS = 12,
>         PM_QID_CLOCK_GET_MAX_DIVISOR = 13,
> +       PM_QID_PINCTRL_GET_ATTRIBUTES = 15,

Any reason why do you need to skip 14 and use 15 here ?

>  };
> 
>  enum rpu_oper_mode {
> --
> 2.25.1
>