Re: [PATCH 08/12] wifi: mwifiex: simplify mwifiex_setup_ht_caps()

From: Francesco Dolcini
Date: Mon Sep 09 2024 - 13:06:28 EST


On Mon, Aug 26, 2024 at 01:01:29PM +0200, Sascha Hauer wrote:
> In mwifiex_setup_ht_caps() first a local struct ieee80211_mcs_info
> is initialized and afterwards copied over &ht_info->mcs. Simplify
> this by initializing &ht_info->mcs directly.
>
> While at it call memset on the u8 rx_mask[] array instead of the struct
> which makes the intention clearer and we no longer have to assume the
> rx_mask array is the first member of struct ieee80211_mcs_info.
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

I had a look at this, and it seems correct to me.

However my brain was really really confused to understand the previous code.
Better if someone else have a look also.

Francesco