Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages

From: Uladzislau Rezki
Date: Mon Sep 09 2024 - 13:52:50 EST


On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote:
> On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote:
> > In many places, in the comments, we use both "higher-order" and
> > "high-order" to describe the non 0-order pages. That is confusing,
> > because a "higher-order" statement does not reflect what it is
> > compared with.
> >
> > Suggested-by: Baoquan He <bhe@xxxxxxxxxx>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> > ---
> > mm/vmalloc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This looks good to me, thanks.
>
> Reviewed-by: Baoquan He <bhe@xxxxxxxxxx>
>
> By the way, do you plan to clean up the rest of them in other places?
>
urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h
urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c
493: * nr is a running index into the array which helps higher level
urezki@pc638:~/data/raid0/coding/linux-next.git$

What am i missing? Didn't i do it?

--
Uladzislau Rezki