Re: [PATCH 3/5] i2c: Congatec Board Controller i2c bus driver

From: Andi Shyti
Date: Mon Sep 09 2024 - 15:29:58 EST


Hi Thomas,

> >> + if (bus_frequency > CGBC_I2C_FREQ_MAX_HZ ||
> >> + bus_frequency < CGBC_I2C_FREQ_MIN_HZ) {
> >> + dev_warn(i2c->dev, "invalid frequency %u, using default\n", bus_frequency);
> >
> > should this rather be a dev_info()? (supernit: please start with
> > capital leter).
>
> The driver i2c-xlp9xx has a similar message [1] and it uses a dev_warn().
> So I don't know.
> If you think dev_info() is more relevant in this case, I'll change it.
> Supernit will be fixed in next iteration.

Not a binding comment, it looks to me more a dev_info(), if you
prefer you can use dev_warn(). In any case, at this stage, I
don't see this printed anywhere :-)

Thanks,
Andi