Re: [PATCH] mm: z3fold: deprecated ZSWAP_ZPOOL_DEFAULT_Z3FOLD as well

[Yosry Ahmed]

On Mon, Sep 9, 2024 at 1:43 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> On Mon, Sep 9, 2024, at 20:29, Yosry Ahmed wrote:
> > On Mon, Sep 9, 2024 at 1:26 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> >>
> >> -config ZSWAP_ZPOOL_DEFAULT_Z3FOLD
> >> -       bool "z3fold"
> >> -       select Z3FOLD
> >> +config ZSWAP_ZPOOL_DEFAULT_Z3FOLD_DEPRECATED
> >> +       bool "z3foldi (DEPRECATED)"
> >> +       select Z3FOLD_DEPRECATED
> >
> > Thanks for looking into this!
> >
> > I was going to fix this by changing "select Z3FOLD" to "depends on
> > Z3FOLD" instead. It makes the warning go away in my builds. Does this
> > work for you?
>
> I had also thought about this but decided that this would
> make less sense from a user perspective.

I doubt there are any actual users who care :)

>
> If it builds in all configs, I won't complain though.

I will use "depends on Z3FOLD" in v3 just because it's simpler. If
bots complain, I will fallback to your approach.

Thanks!