Re: [PATCH 2/2] pwm: sophgo: add driver for Sophgo SG2042 PWM

From: Chen Wang
Date: Mon Sep 09 2024 - 19:08:39 EST



On 2024/9/9 19:45, Uwe Kleine-König wrote:
Hello Chen,

On Mon, Sep 09, 2024 at 05:08:41PM +0800, Chen Wang wrote:
On 2024/9/9 16:45, Geert Uytterhoeven wrote:
On Mon, Sep 9, 2024 at 10:26 AM Chen Wang <unicorn_wang@xxxxxxxxxxx> wrote:
I wonder why CONFIG_PWM_SOPHGO_SG2042 is enabeld for m68k? Please remove
this.
Because it depends on ARCH_SOPHGO || COMPILE_TEST.
So it can be enabled on all architectures when compile-testing.
Thanks, it's really a potential defect when CONFIG_OF is not set, will fix
this in next version.
BTW, the right approach to fix that is to not use of_match_ptr when
initializing pwm_sg2042_driver.driver.of_match_table.

Best regards
Uwe

Thank you Uwe, that's what I said potential defect, have fixed here.

Thanks,

Chen