Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding
From: Jakub Kicinski
Date: Mon Sep 09 2024 - 19:51:29 EST
On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote:
> > This seems to be a bug in the driver.
> >
> > A call to skb_put_padto(skb, ETH_ZLEN) should be added.
>
> In which case this test detecting it may be nice to have, for lack of
> a more targeted test.
IIUC we're basically saying that we don't need to trim because pad
should be 0? In that case maybe let's keep the patch but add a check
on top which scans the pad for non-zero bytes, and print an informative
warning?