RE: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on different channel

[David Lin]

> From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Sent: Tuesday, September 10, 2024 5:05 AM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: linux-wireless@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx; francesco@xxxxxxxxxx; Pete
> Hsieh <tsung-hsien.hsieh@xxxxxxx>
> Subject: [EXT] Re: [PATCH v2] wifi: mwifiex: avoid AP and STA running on
> different channel
> 
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
> 
> 
> On Mon, Sep 02, 2024 at 04:43:11PM +0800, David Lin wrote:
> > Current firmware doesn't support AP and STA running on different
> > channels simultaneously.
> > FW crash would occur in such case.
> > This patch avoids the issue by disabling AP and STA to run on
> > different channels.
> >
> > Signed-off-by: David Lin <yu-hao.lin@xxxxxxx>
> > ---
> >
> > v2:
> >    - clean up code.
> >
> > ---
> >  .../net/wireless/marvell/mwifiex/cfg80211.c   | 17 ++++---
> >  drivers/net/wireless/marvell/mwifiex/util.c   | 44 +++++++++++++++++++
> >  drivers/net/wireless/marvell/mwifiex/util.h   | 13 ++++++
> >  3 files changed, 69 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > index 722ead51e912..3dbcab463445 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c
> > @@ -781,11 +781,9 @@ mwifiex_cfg80211_set_wiphy_params(struct wiphy
> *wiphy, u32 changed)
> >               break;
> >
> >       case MWIFIEX_BSS_ROLE_STA:
> > -             if (priv->media_connected) {
> > -                     mwifiex_dbg(adapter, ERROR,
> > -                                 "cannot change wiphy params
> when connected");
> > -                     return -EINVAL;
> > -             }
> > +             if (priv->media_connected)
> > +                     break;
> 
> This hunk seems unrelated to this patch. If this is needed then it deserves an
> extra patch along with an explanation why this is necessary.
> 
> Sascha
> 

Without this hunk, AP and STA can't run on the same channel if some wiphy parameters are setting.

David