Re: [PATCH v3 1/1] arm64: dts: qcom: Add coresight nodes for x1e80100

[JieGan]

On Mon, Sep 09, 2024 at 10:05:08PM +0200, Konrad Dybcio wrote:
> On 5.09.2024 12:38 PM, Jie Gan wrote:
> > Add following coresight components for x1e80100 platform.
> > It includes CTI, dummy sink, dynamic Funnel, Replicator, STM,
> > TPDM, TPDA and TMC ETF.
> > 
> > Signed-off-by: Jie Gan <quic_jiegan@xxxxxxxxxxx>
> > Tested-by: Yushan Li <quic_yushli@xxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1516 ++++++++++++++++++++++++
> >  1 file changed, 1516 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index 74b694e74705..9d6f3098e144 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -305,6 +305,19 @@ CLUSTER_CL5: cluster-sleep-1 {
> >  		};
> >  	};
> >  
> > +	dummy-sink {
> > +		compatible = "arm,coresight-dummy-sink";
> > +
> > +		in-ports {
> > +			port {
> > +				eud_in: endpoint {
> > +					remote-endpoint =
> > +					<&swao_rep_out1>;
> 
> Don't be scared to keep the lines 100-long, easier to read that way
>
sure, will fix in next version.
 
> [...]
> 
> > +		tpda@10004000 {
> > +			compatible = "qcom,coresight-tpda", "arm,primecell";
> > +			reg = <0x0 0x10004000 0x0 0x1000>;
> > +
> > +			clocks = <&aoss_qmp>;
> > +			clock-names = "apb_pclk";
> > +
> > +			out-ports {
> > +				port {
> > +					qdss_tpda_out: endpoint {
> > +						remote-endpoint =
> > +						<&funnel0_in6>;
> > +					};
> > +				};
> > +			};
> > +
> > +			in-ports {
> 
> 'i' < 'o', please sort things alphabetically if there's no other sorting key
> as per Documentation/devicetree/bindings/dts-coding-style.rst
> 
Will sort with alphabet order for "in-ports" and "out-ports" property.

> [...]
> 
> > +		tpda@10c2b000 {
> > +			compatible = "qcom,coresight-tpda", "arm,primecell";
> > +			reg = <0x0 0x10c2b000 0x0 0x1000>;
> > +
> > +			clocks = <&aoss_qmp>;
> > +			clock-names = "apb_pclk";
> > +
> > +			out-ports {
> > +				port {
> > +					dlct1_tpda_out: endpoint {
> > +						remote-endpoint =
> > +						<&dlct1_funnel_in0>;
> > +					};
> > +				};
> > +			};
> > +
> > +			in-ports {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +
> > +				port@4 {
> > +					reg = <4>;
> > +					dlct1_tpda_in4: endpoint {
> 
> Please keep a new line between the last property (reg here) and the
> following subnode
> 
Will fix in next version.

> I was able to confirm that this patch doesn't break booting on the
> Surface laptop anymore.
> 
> Konrad

Thanks for testing!

Thanks,
Jie