Re: [PATCH v3 2/2] iio: imu: Add i2c driver for bmi270 imu

From: Alex Lanzano
Date: Mon Sep 09 2024 - 23:24:29 EST

Next message: Stephen Rothwell: "linux-next: manual merge of the security tree with the vfs-brauner tree"
Previous message: Jeongjun Park: "Re: [PATCH net] net: prevent NULL pointer dereference in rt_fibinfo_free() and rt_fibinfo_free_cpus()"
In reply to: kernel test robot: "Re: [PATCH v3 2/2] iio: imu: Add i2c driver for bmi270 imu"
Next in thread: Vasileios Amoiridis: "Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, Sep 10, 2024 at 06:13:04AM GMT, kernel test robot wrote:
> Hi Alex,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on jic23-iio/togreg]
> [also build test ERROR on robh/for-next linus/master v6.11-rc7 next-20240909]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Alex-Lanzano/dt-bindings-iio-imu-add-bmi270-bindings/20240909-123509
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
> patch link: https://lore.kernel.org/r/20240909043254.611589-3-lanzano.alex%40gmail.com
> patch subject: [PATCH v3 2/2] iio: imu: Add i2c driver for bmi270 imu
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240910/202409100526.LydCADNj-lkp@xxxxxxxxx/config)
> compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 05f5a91d00b02f4369f46d076411c700755ae041)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240910/202409100526.LydCADNj-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202409100526.LydCADNj-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/iio/imu/bmi270/bmi270_core.c:4:
> In file included from include/linux/i2c.h:19:
> In file included from include/linux/regulator/consumer.h:35:
> In file included from include/linux/suspend.h:5:
> In file included from include/linux/swap.h:9:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 548 | val = __raw_readb(PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
> | ~~~~~~~~~~ ^
> include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
> 37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
> | ^
> In file included from drivers/iio/imu/bmi270/bmi270_core.c:4:
> In file included from include/linux/i2c.h:19:
> In file included from include/linux/regulator/consumer.h:35:
> In file included from include/linux/suspend.h:5:
> In file included from include/linux/swap.h:9:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
> | ~~~~~~~~~~ ^
> include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
> 35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
> | ^
> In file included from drivers/iio/imu/bmi270/bmi270_core.c:4:
> In file included from include/linux/i2c.h:19:
> In file included from include/linux/regulator/consumer.h:35:
> In file included from include/linux/suspend.h:5:
> In file included from include/linux/swap.h:9:
> In file included from include/linux/memcontrol.h:13:
> In file included from include/linux/cgroup.h:25:
> In file included from include/linux/kernel_stat.h:8:
> In file included from include/linux/interrupt.h:11:
> In file included from include/linux/hardirq.h:11:
> In file included from ./arch/hexagon/include/generated/asm/hardirq.h:1:
> In file included from include/asm-generic/hardirq.h:17:
> In file included from include/linux/irq.h:20:
> In file included from include/linux/io.h:14:
> In file included from arch/hexagon/include/asm/io.h:328:
> include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 585 | __raw_writeb(value, PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
> 605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
> | ~~~~~~~~~~ ^
> In file included from drivers/iio/imu/bmi270/bmi270_core.c:4:
> In file included from include/linux/i2c.h:19:
> In file included from include/linux/regulator/consumer.h:35:
> In file included from include/linux/suspend.h:5:
> In file included from include/linux/swap.h:9:
> In file included from include/linux/memcontrol.h:21:
> In file included from include/linux/mm.h:2228:
> include/linux/vmstat.h:517:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
> 517 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
> | ~~~~~~~~~~~ ^ ~~~
> >> drivers/iio/imu/bmi270/bmi270_core.c:180:10: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 180 | FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
> | ^
> 7 warnings and 1 error generated.
>
>
> vim +/FIELD_PREP +180 drivers/iio/imu/bmi270/bmi270_core.c
>
> 165
> 166 static int bmi270_configure_imu(struct bmi270_data *bmi270_device)
> 167 {
> 168 int ret;
> 169 struct device *dev = bmi270_device->dev;
> 170 struct regmap *regmap = bmi270_device->regmap;
> 171
> 172 ret = regmap_set_bits(regmap, BMI270_PWR_CTRL_REG,
> 173 BMI270_PWR_CTRL_AUX_EN_MSK |
> 174 BMI270_PWR_CTRL_GYR_EN_MSK |
> 175 BMI270_PWR_CTRL_ACCEL_EN_MSK);
> 176 if (ret)
> 177 return dev_err_probe(dev, ret, "Failed to enable accelerometer and gyroscope");
> 178
> 179 ret = regmap_set_bits(regmap, BMI270_ACC_CONF_REG,
> > 180 FIELD_PREP(BMI270_ACC_CONF_ODR_MSK,
> 181 BMI270_ACC_CONF_ODR_100HZ) |
> 182 FIELD_PREP(BMI270_ACC_CONF_BWP_MSK,
> 183 BMI270_ACC_CONF_BWP_NORMAL_MODE) |
> 184 BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> 185 if (ret)
> 186 return dev_err_probe(dev, ret, "Failed to configure accelerometer");
> 187
> 188 ret = regmap_set_bits(regmap, BMI270_GYR_CONF_REG,
> 189 FIELD_PREP(BMI270_GYR_CONF_ODR_MSK,
> 190 BMI270_GYR_CONF_ODR_200HZ) |
> 191 FIELD_PREP(BMI270_GYR_CONF_BWP_MSK,
> 192 BMI270_GYR_CONF_BWP_NORMAL_MODE) |
> 193 BMI270_PWR_CONF_ADV_PWR_SAVE_MSK);
> 194 if (ret)
> 195 return dev_err_probe(dev, ret, "Failed to configure gyroscope");
> 196
> 197 /* Enable FIFO_WKUP, Disable ADV_PWR_SAVE and FUP_EN */
> 198 ret = regmap_write(regmap, BMI270_PWR_CONF_REG,
> 199 BMI270_PWR_CONF_FIFO_WKUP_MSK);
> 200 if (ret)
> 201 return dev_err_probe(dev, ret, "Failed to set power configuration");
> 202
> 203 return 0;
> 204 }
> 205
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

I am having trouble reproducing this build error on both jic23-iio/togreg and
linus/master v6.11.rc7 on an aarch64 box with the same compiler version.
Maybe a config option is causing this?

However, I will add #include <linux/bitfield.h> to remedy this issue if
some edge case is being hit.

Best regards,
Alex

Next message: Stephen Rothwell: "linux-next: manual merge of the security tree with the vfs-brauner tree"
Previous message: Jeongjun Park: "Re: [PATCH net] net: prevent NULL pointer dereference in rt_fibinfo_free() and rt_fibinfo_free_cpus()"
In reply to: kernel test robot: "Re: [PATCH v3 2/2] iio: imu: Add i2c driver for bmi270 imu"
Next in thread: Vasileios Amoiridis: "Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]