Re: [PATCH] locking/rwsem: Move is_rwsem_reader_owned() and rwsem_owner() under CONFIG_DEBUG_RWSEMS

From: Andy Shevchenko
Date: Tue Sep 10 2024 - 04:17:37 EST


On Mon, Sep 09, 2024 at 02:29:05PM -0400, Waiman Long wrote:
> Both is_rwsem_reader_owned() and rwsem_owner() are currently only used when
> CONFIG_DEBUG_RWSEMS is defined. This causes a compilation error with clang
> when `make W=1` and CONFIG_WERROR=y:
>
> kernel/locking/rwsem.c:187:20: error: unused function 'is_rwsem_reader_owned' [-Werror,-Wunused-function]
> 187 | static inline bool is_rwsem_reader_owned(struct rw_semaphore *sem)
> | ^~~~~~~~~~~~~~~~~~~~~
> kernel/locking/rwsem.c:271:35: error: unused function 'rwsem_owner' [-Werror,-Wunused-function]
> 271 | static inline struct task_struct *rwsem_owner(struct rw_semaphore *sem)
> | ^~~~~~~~~~~
>
> Fix this by moving these two functions under the CONFIG_DEBUG_RWSEMS define.

At least this solves my issue,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Thanks!

--
With Best Regards,
Andy Shevchenko