RE: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting for pca9555

[Delphine_CC_Chiu/WYHQ/Wiwynn]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Sent: Tuesday, September 10, 2024 3:31 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@xxxxxxxxxx>;
> patrick@xxxxxxxxx; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Joel Stanley
> <joel@xxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxxxxxxxxxxxxxx>
> Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx;
> linux-aspeed@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1] ARM: dts: aspeed: yosemite4: Enable interrupt setting
> for pca9555
> 
>  [External Sender]
> 
>  [External Sender]
> 
> On 10/09/2024 08:39, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> >
> > Enable interrupt setting and add GPIO line name for pca9555 for the
> > I/O expanders on Medusa board.
> >
> > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@xxxxxxxxx>
> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@xxxxxxxxxx>
> > ---
> >  .../aspeed/aspeed-bmc-facebook-yosemite4.dts  | 52
> > +++++++++++++++++--
> >  1 file changed, 48 insertions(+), 4 deletions(-)
> >
> > diff --git
> > a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > index 98477792aa00..cb2436031181 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> > @@ -295,30 +295,74 @@ power-sensor@12 {
> >
> >       gpio@20 {
> >               compatible = "nxp,pca9555";
> > -             reg = <0x20>;
> >               gpio-controller;
> >               #gpio-cells = <2>;
> > +             reg = <0x20>;
> 
> Hm? Why? The placement is after compatible.
> 
I will revise in v2. Thanks!
> > +             interrupt-parent = <&gpio0>;
> > +             interrupts = <98 IRQ_TYPE_LEVEL_LOW>;
> > +             gpio-line-names =
> > +             "P48V_OCP_GPIO1","P48V_OCP_GPIO2",
> 
> Nothing improved here. I already commented about above and this.
> Implement feedback for all your patches, not only one.
> 
> Best regards,
> Krzysztof
Sorry about that.
I saw you say "Broken alignment" in v15 patch.
Would like to ask if the following format meets your expectations?
+			gpio-line-names =
+				"P48V_OCP_GPIO1", "P48V_OCP_GPIO2",
+				"P48V_OCP_GPIO3", "FAN_BOARD_0_REVISION_0_R",