Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages

[Uladzislau Rezki]

On Tue, Sep 10, 2024 at 08:40:42AM +0800, Baoquan He wrote:
> On 09/09/24 at 07:52pm, Uladzislau Rezki wrote:
> > On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote:
> > > On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote:
> > > > In many places, in the comments, we use both "higher-order" and
> > > > "high-order" to describe the non 0-order pages. That is confusing,
> > > > because a "higher-order" statement does not reflect what it is
> > > > compared with.
> > > > 
> > > > Suggested-by: Baoquan He <bhe@xxxxxxxxxx>
> > > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> > > > ---
> > > >  mm/vmalloc.c | 4 ++--
> > > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > This looks good to me, thanks.
> > > 
> > > Reviewed-by: Baoquan He <bhe@xxxxxxxxxx>
> > > 
> > > By the way, do you plan to clean up the rest of them in other places?
> > > 
> > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h 
> > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c
> > 493:     * nr is a running index into the array which helps higher level
> > urezki@pc638:~/data/raid0/coding/linux-next.git$
> > 
> > What am i missing? Didn't i do it?
> 
> Sorry, I didn't make it clear. I meant those places other than vmalloc
> related files, e.g mm/page_alloc.c, there are a lot of [Hhigh]er-order
> mixed with high-order. I can continue the cleaning sometime if it's not
> in your TO-DO list.
> 
> mm/page_alloc.c:551: * Higher-order pages are called "compound pages".  They are structured thusly:
> mm/page_alloc.c:716: * of the next-higher order is free. If it is, it's possible
> mm/page_alloc.c:720: * as a 2-level higher order page
> mm/page_alloc.c:735:    return find_buddy_page_pfn(higher_page, higher_page_pfn, order + 1,
> mm/page_alloc.c:2750: * split_page takes a non-compound higher-order page, and splits it into
> mm/page_alloc.c:3587:   /* The OOM killer will not help higher order allocs */
> mm/page_alloc.c:4811: *  within a 0 or higher order page.  Multiple fragments within that page
> mm/page_alloc.c:6516:    * page allocator holds, ie. they can be part of higher order
> mm/page_alloc.c:6790: * Break down a higher-order page in sub-pages, and keep our target out of
> 
I see. I appreciate if you go ahead and improve it further.

--
Uladzislau Rezki