Re: [PATCH v2 2/2] x86/mm/sme: fix the kdump kernel breakage on SME system when CONFIG_IMA_KEXEC=y

From: Baoquan He
Date: Tue Sep 10 2024 - 05:41:31 EST


On 09/09/24 at 09:53am, Tom Lendacky wrote:
> On 8/29/24 05:40, Baoquan He wrote:
......snip..
> > Here fix the code bug to make kexec/kdump kernel boot up successfully.
> >
> > And also fix the similar buggy code in memremap_is_setup_data() which
> > are found out during code reviewing.
>
> I think you should add something along the lines that the "len" variable
> in struct setup_data is the length of the "data" field and does not
> include the size of the struct, which is the reason for the miscalculation.

Fair enough. I will send v3 to add the reason of miscalculation.

>
> Otherwise:
>
> Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

Thanks a lot for careful checking.