Re: [PATCH v5 02/12] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible
From: Théo Lebrun
Date: Tue Sep 10 2024 - 06:05:57 EST
On Fri Jul 26, 2024 at 9:26 PM CEST, Rob Herring (Arm) wrote:
> On Fri, 26 Jul 2024 20:17:50 +0200, Théo Lebrun wrote:
> > On J7200, the controller & its wrapper are reset on resume. It has the
> > same behavior as ti,j721e-usb with a different SoC integration.
> >
> > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
Clearly this patch was wrong.
Past me trusted future me to verify and future me trusted past me.
Sorry!
For reference, new patch content will look like below.
This doesn't trigger a warning on:
make dt_binding_check DT_SCHEMA_FILES=ti,j721e-usb
------------------------------------------------------------------------
diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
index 653a89586f4e..d14c18b64086 100644
--- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
+++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml
@@ -14,7 +14,9 @@ properties:
oneOf:
- const: ti,j721e-usb
- items:
- - const: ti,am64-usb
+ - enum:
+ - ti,am64-usb
+ - ti,j7200-usb
- const: ti,j721e-usb
reg:
------------------------------------------------------------------------
Regards,
--
Théo Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com